-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize cmm shifts and tags #3669
Conversation
Array.length gets compiled worse now, i need to fix that
the latter doesn't turn into a |
cd768b1
to
93513c0
Compare
array length looks strictly better now, the only problems are in cmm-scalar-type, which i'll fix in yet another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be good to merge once comment have been adressed/answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments/questions, but as far as code semantics goes, we should be good !
@jvanburen there are review comments waiting for your attention here! |
yes i'm getting to them! Other things came up :/ |
1e6d71b
to
3f9e7ad
Compare
i just rebased onto main, no new changes |
This will be used by a future pr to simplify casting without impacting performance as much
3f9e7ad
to
9d7883c
Compare
^another rebase |
One last performance regression that I can tell:
cmm:
leads to
instead of
|
…n the outside and makes optimization better overall.
I think i fixed these regressions by removing some "optimizations" that kept us from moving shifts outward |
add some optimizations for shifts and tags in preparation for cmm-scalar-type, which needs these to keep decent performance